Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video.py read_video_timestamps (follow-up PR #2202) #2268

Merged
merged 5 commits into from May 29, 2020
Merged

video.py read_video_timestamps (follow-up PR #2202) #2268

merged 5 commits into from May 29, 2020

Conversation

mjunyent
Copy link
Contributor

Following the merged PR #2202 I added a try/except surrounding not only the decode but both methods to get the video_frames as I assume demux can also fail.

@mjunyent mjunyent changed the title Follow-up PR #2202 video.py read_video_timestamps (follow-up PR #2202) May 27, 2020
fmassa
fmassa approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit a85f21d into pytorch:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjunyent @fmassa