Refactoring to use contexts managers, list comprehensions when more idiomatic, and minor renaming to help reader clarity #2335
Conversation
…diomatic, and minor renaming to help reader clarity.
| def __init__(self, x): | ||
| self.x = x | ||
| def __init__(self, video_paths: List[str]): | ||
| self.video_paths = video_paths |
There was a problem hiding this comment.
nit: this is fine because this is a private class, but in general renaming methods is a BC-breaking change
| frame = av.VideoFrame.from_ndarray(img, format="rgb24") | ||
| frame.pict_type = "NONE" | ||
| for packet in stream.encode(frame): | ||
| with av.open(filename, mode="w") as container: |
There was a problem hiding this comment.
thanks! PyAV only added support for using open as a context-manager in 6.2.0, which was after we released this first version.
This clean-up is much appreciated!
|
Lint is failing in https://app.circleci.com/pipelines/github/pytorch/vision/2948/workflows/a769a571-a0d6-46f9-9de8-a1ed3c4be2b0/jobs/162851/steps with can you fix it? |
Indeed! It should be fixed at the latest commit. |
|
There is a conflict now that I merged your other PR. Could you address it please? |
No description provided.