Fix wrong clamping in RoIAlign with aligned=True #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppwwyyxx
reviewed
Jul 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #2438 +/- ##
==========================================
- Coverage 70.69% 70.58% -0.12%
==========================================
Files 94 94
Lines 7920 7920
Branches 1249 1249
==========================================
- Hits 5599 5590 -9
- Misses 1934 1943 +9
Partials 387 387
Continue to review full report at Codecov.
|
ppwwyyxx
approved these changes
Jul 9, 2020
|
Will add tests in a follow-up PR which is being tracked in #2440 |
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Jul 9, 2020
* Fix wrong clamping in RoIAlign with aligned=True * Fix silly mistake * Bugfix pointed out during code-review
fmassa
added a commit
that referenced
this pull request
Jul 9, 2020
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Jul 9, 2020
* Fix wrong clamping in RoIAlign with aligned=True * Fix silly mistake * Bugfix pointed out during code-review
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 9, 2020
Summary: * Fix wrong clamping in RoIAlign with aligned=True * Fix silly mistake * Bugfix pointed out during code-review Pull Request resolved: #2445 Reviewed By: zhangguanheng66 Differential Revision: D22458789 Pulled By: fmassa fbshipit-source-id: cbe4d7df64b56b2c0b44c21c3fb155d40c74e057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug pointed out by @ppwwyyxx in #1908 (comment)