Clarify scaling of ToTensor transform for target masks in the documentation #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
- Coverage 70.60% 70.46% -0.15%
==========================================
Files 94 94
Lines 7995 9091 +1096
Branches 1272 1663 +391
==========================================
+ Hits 5645 6406 +761
- Misses 1947 2223 +276
- Partials 403 462 +59
Continue to review full report at Codecov.
|
Co-authored-by: vfdev <vfdev.5@gmail.com>
|
Thanks for adding the link, I committed your change. |
fmassa
approved these changes
Aug 3, 2020
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
…tation (pytorch#2507) * Clarify scaling of ToTensor transform for target masks in the documentation * Add link to the segmentation reference Co-authored-by: vfdev <vfdev.5@gmail.com> Co-authored-by: vfdev <vfdev.5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2497 this should clarify that the scope of ToTensor() does not include target image masks, but only input images, because masks will be subject to the [0,1] scaling which is not desired.
I was not sure if I should add a link to the references (https://github.com/pytorch/vision/tree/master/references) and what the format in the documentation should be (absolute/relative link?).