Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typehints for torchvision.datasets.vision #2526

Merged
merged 1 commit into from Jul 31, 2020
Merged

add typehints for torchvision.datasets.vision #2526

merged 1 commit into from Jul 31, 2020

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jul 30, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited

Codecov Report

Merging #2526 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2526   +/-   ##
=======================================
  Coverage   70.65%   70.65%           
=======================================
  Files          94       94           
  Lines        8007     8008    +1     
  Branches     1276     1276           
=======================================
+ Hits         5657     5658    +1     
  Misses       1945     1945           
  Partials      405      405
Impacted Files Coverage Δ
torchvision/datasets/vision.py 48.27% <100.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b02965...cdbb6b9. Read the comment docs.

fmassa
fmassa approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 5405739 into pytorch:master Jul 31, 2020
@pmeier pmeier deleted the typehints-vision branch July 31, 2020 16:47
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@pmeier @bryant1410
vision (pytorch#2526)
e5438cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmeier @fmassa