add typehints for torchvision.datasets.mnist #2532
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2532 +/- ##
=======================================
Coverage 70.68% 70.68%
=======================================
Files 94 94
Lines 8017 8017
Branches 1276 1275 -1
=======================================
Hits 5667 5667
Misses 1945 1945
Partials 405 405
Continue to review full report at Codecov.
|
| """Read a SN3 file in "Pascal Vincent" format (Lush file 'libidx/idx-io.lsh'). | ||
| Argument may be a filename, compressed filename, or file object. | ||
| """ | ||
| # typemap | ||
| if not hasattr(read_sn3_pascalvincent_tensor, 'typemap'): |
There was a problem hiding this comment.
Not sure what the original intention was to assign this dict to the function in the first run instead as a constant on the outside. I didn't manage to annotate it so that mypy didn't complain, so I moved it outside.
There was a problem hiding this comment.
It's a micro-optimization, but It's ok to change it as you did. I would even put it inside the function itself, so that it doesn't appear in the global namespace of mnist.
No description provided.