Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests on batch of tensors to check transforms #2584

Merged
merged 7 commits into from Sep 18, 2020
Merged

Added tests on batch of tensors to check transforms #2584

merged 7 commits into from Sep 18, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 13, 2020 •
edited

Related to #2583

Description:

  • Updated functional transforms to work on batch of tensor images, i.e. (N, C, H, W)
  • Added tests to check functional transforms on batch of image tensors (N, C, H, W)
  • Added tests to check transforms on batch of image tensors (N, C, H, W)
  • Updated docs

@codecov
Copy link

codecov bot commented Sep 11, 2020 •
edited

Codecov Report

Merging #2584 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
+ Coverage   72.42%   72.57%   +0.15%     
==========================================
  Files          95       95              
  Lines        8246     8249       +3     
  Branches     1308     1309       +1     
==========================================
+ Hits         5972     5987      +15     
+ Misses       1859     1855       -4     
+ Partials      415      407       -8
Impacted Files Coverage Δ
torchvision/transforms/functional_tensor.py 70.08% <100.00%> (+2.41%) ⬆️
torchvision/transforms/functional.py 82.13% <0.00%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36dc43...846d5d5. Read the comment docs.

@vfdev-5 vfdev-5 marked this pull request as ready for review September 15, 2020 16:11
@vfdev-5 vfdev-5 changed the title [WIP] Added tests on batch of tensors to check transforms Added tests on batch of tensors to check transforms Sep 16, 2020
@vfdev-5 vfdev-5 requested a review from fmassa September 16, 2020 15:30
fmassa
fmassa approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit c4dcfb0 into pytorch:master Sep 18, 2020
@vfdev-5 vfdev-5 deleted the vfdev-5/issue-2292-batch branch September 18, 2020 14:54
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@vfdev-5 @bryant1410
Added tests on batch of tensors to check transforms (pytorch#2584)
fc99a5a 
* [WIP] Added tests on batch of tensors

* Updated tests on batch of images

* All functional transforms can work with (..., C, H, W) format

* Added transforms tests on batch tensors

* Added batch tests for five/ten crop
- updated docs
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@vfdev-5
Added tests on batch of tensors to check transforms (pytorch#2584)
27eda2d 
* [WIP] Added tests on batch of tensors

* Updated tests on batch of images

* All functional transforms can work with (..., C, H, W) format

* Added transforms tests on batch tensors

* Added batch tests for five/ten crop
- updated docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vfdev-5 @fmassa