add typehints for .datasets.samplers #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Sep 11, 2020
| @@ -164,11 +172,10 @@ def __iter__(self): | |||
| sampled = torch.randperm(length)[:size] + s | |||
| s += length | |||
| idxs.append(sampled) | |||
| idxs = torch.cat(idxs) | |||
There was a problem hiding this comment.
This scheme of overriding the variable type was quite common here. In this example idxs was List[torch.Tensor] before, torch.Tensor here, and List[int] later. Thus, I need to rename some variables or merge statements to avoid assignments all together. Otherwise, this will be an even more complicated mess with a lot of casting.
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.