Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make JPEG/PNG reading ops return images in CHW format #2680

Merged
merged 2 commits into from Sep 18, 2020

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Sep 16, 2020

This PR makes image reading operations (JPEG/PNG) return tensors in CHW format

Fixes #2616

@andfoy andfoy self-assigned this Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #2680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2680   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files          95       95           
  Lines        8246     8246           
  Branches     1308     1308           
=======================================
  Hits         5972     5972           
  Misses       1859     1859           
  Partials      415      415           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36dc43...006ccc4. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit 5e4a9f6 into pytorch:master Sep 18, 2020
@fmassa
Copy link
Member

fmassa commented Sep 18, 2020

@andfoy for a follow-up PR, can you change the docstrings in

output (Tensor[image_width, image_height, 3])
and
output (Tensor[image_width, image_height, 3])
(and the other functions in this file)?

bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
* Make JPEG/PNG return images in CHW format

* Use int array
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
* Make JPEG/PNG return images in CHW format

* Use int array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make image reading ops return tensors in CHW
2 participants