Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake interface dependency #2684

Merged
merged 2 commits into from Sep 21, 2020

Conversation

martingasser
Copy link
Contributor

I added an INTERFACE dependency to the TorchVision::TorchVision target, which simplifies installing the C++ library to arbitrary locations.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #2684 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2684      +/-   ##
==========================================
- Coverage   72.57%   72.42%   -0.16%     
==========================================
  Files          95       95              
  Lines        8249     8246       -3     
  Branches     1309     1308       -1     
==========================================
- Hits         5987     5972      -15     
- Misses       1855     1859       +4     
- Partials      407      415       +8     
Impacted Files Coverage Δ
torchvision/transforms/functional_tensor.py 67.66% <0.00%> (-2.42%) ⬇️
torchvision/transforms/functional.py 80.97% <0.00%> (-1.16%) ⬇️
torchvision/io/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2801a76...cd2478e. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit fc49090 into pytorch:master Sep 21, 2020
@martingasser martingasser deleted the cmake_interface_dependency branch September 21, 2020 12:24
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants