Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check JPEG_FOUND macro in jpeg common definitions #2725

Merged
merged 1 commit into from Sep 29, 2020
Merged

Check JPEG_FOUND macro in jpeg common definitions #2725

merged 1 commit into from Sep 29, 2020

Conversation

andfoy
Copy link
Contributor

@andfoy andfoy commented Sep 28, 2020

This PR prevents further compilation errors when libjepg/turbo is not found

Fixes #2724

@andfoy andfoy self-assigned this Sep 28, 2020
@andfoy andfoy mentioned this pull request Sep 28, 2020
Closed
@codecov
Copy link

codecov bot commented Sep 28, 2020 •
edited

Codecov Report

Merging #2725 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2725   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files          95       95           
  Lines        8233     8233           
  Branches     1279     1279           
=======================================
  Hits         6003     6003           
  Misses       1838     1838           
  Partials      392      392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afb349...1ecb718. Read the comment docs.

fmassa
fmassa approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm thinking if we should have a dummy CI that tries compiling / running torchvision without installing libjpeg / libpng, just to make sure that we don't regress this in the future.

@fmassa fmassa merged commit 6f75883 into pytorch:master Sep 29, 2020
@andfoy andfoy deleted the set_jpeg_macro_common branch September 29, 2020 15:34
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@andfoy @bryant1410
Check JPEG_FOUND macro in jpeg common definitions (pytorch#2725)
c319b97
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@andfoy @vfdev-5
Check JPEG_FOUND macro in jpeg common definitions (pytorch#2725)
2123e64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees

@andfoy andfoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: 'jpeglib.h' file not found
2 participants
@andfoy @fmassa