Negative padding for functional_tensor symmetric #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with pytorch#2744 this will make negative padding uniform between PIL and Tensor pytorch#2381
|
@jamt9000 thanks for the PR. I merged your previous PR, can you please update this one and add missing tests and fix currently failing one. Thanks ! |
jamt9000
force-pushed
the
negative_pad_tensor_symmetric
branch
from
9dc0602
to
2cbf368
Compare
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
=======================================
Coverage 73.08% 73.09%
=======================================
Files 96 96
Lines 8319 8321 +2
Branches 1293 1295 +2
=======================================
+ Hits 6080 6082 +2
Misses 1840 1840
Partials 399 399
Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Negative padding for functional_tensor symmetric Along with pytorch#2744 this will make negative padding uniform between PIL and Tensor pytorch#2381 * Enable tests for negative symmetric pad with tensor Co-authored-by: vfdev <vfdev.5@gmail.com>
vfdev-5
added a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Negative padding for functional_tensor symmetric Along with pytorch#2744 this will make negative padding uniform between PIL and Tensor pytorch#2381 * Enable tests for negative symmetric pad with tensor Co-authored-by: vfdev <vfdev.5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with #2744 this will make negative padding
uniform between PIL and Tensor #2381
The natural test would be not excluding "symmetric" here but that relies on the changes in #2744 so I haven't included it here yet.