Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use more precise return type for gzip.open() #2792

Merged
merged 1 commit into from Oct 12, 2020

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 11, 2020

Fixes #2790

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #2792 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
+ Coverage   73.22%   73.25%   +0.02%     
==========================================
  Files          96       96              
  Lines        8431     8431              
  Branches     1317     1317              
==========================================
+ Hits         6174     6176       +2     
+ Misses       1857     1855       -2     
  Partials      400      400              
Impacted Files Coverage Δ
torchvision/datasets/mnist.py 55.25% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831c0df...2e2969e. Read the comment docs.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vfdev-5 vfdev-5 merged commit f9c4fdf into pytorch:master Oct 12, 2020
@pmeier pmeier deleted the fix-typehints branch October 21, 2020 15:07
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python_type_check CI is broken
3 participants