Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FBcode->GH] Fix to_tensor for accimage backend #3439

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[FBcode->GH] Fix to_tensor for accimage backend #3439

merged 1 commit into from
Feb 23, 2021

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Feb 23, 2021

Fixes bug introduced in #3398 for accimage backends.

accimage only supports uint8 and float types, plus we were passing a torch.dtype into np.zeros causing errors.

accimage is not tested in OSS CI and that's why this wasn't caught before, we caught it in internal fb tests when importing it.

Note: this has already been fixed in fbcode

@fmassa fmassa requested a review from vfdev-5 February 23, 2021 14:16
vfdev-5
vfdev-5 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing it!

@fmassa fmassa merged commit 67681a7 into pytorch:master Feb 23, 2021
@fmassa fmassa deleted the fix-accimg-to_tensor branch February 23, 2021 14:59
@datumbox datumbox added bug and removed fix labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
bug cla signed module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fmassa @vfdev-5 @NicolasHug @datumbox @facebook-github-bot