Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate _transforms_video and _functional_video #3441

Merged
merged 4 commits into from
Feb 26, 2021

Conversation

NicolasHug
Copy link
Member

These modules are private and they have equivalent transforms in the transform module.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #3441 (5c7b211) into master (2e8c124) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3441   +/-   ##
=======================================
  Coverage   76.11%   76.12%           
=======================================
  Files         105      105           
  Lines        9697     9701    +4     
  Branches     1556     1556           
=======================================
+ Hits         7381     7385    +4     
  Misses       1836     1836           
  Partials      480      480           
Impacted Files Coverage Δ
torchvision/transforms/_functional_video.py 95.45% <100.00%> (+0.21%) ⬆️
torchvision/transforms/_transforms_video.py 89.23% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8c124...5c7b211. Read the comment docs.

@datumbox datumbox merged commit 74d5e71 into pytorch:master Feb 26, 2021
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
Summary:
* deprecate _video modules

* flake8

Reviewed By: fmassa

Differential Revision: D26756260

fbshipit-source-id: 12b4e96a0127ea10d5bf9ce3d348ba4e1df65a04

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants