.circleci: Don't install numpy directly #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems we still need mypy from the failing python_type_check test |
numpy is a dependency of pytorch so we should let the package manager resolve our numpy dependency instead of doing it ourselves Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
force-pushed
the
no_install_numpy_directly
branch
from
303e69f
to
86c5539
Compare
Re-added and changed the install command for pytorch to be channel specific |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Codecov Report
@@ Coverage Diff @@
## master #3444 +/- ##
=======================================
Coverage 76.00% 76.00%
=======================================
Files 105 105
Lines 9697 9697
Branches 1556 1556
=======================================
Hits 7370 7370
Misses 1841 1841
Partials 486 486 Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
Reviewed By: fmassa Differential Revision: D26756262 fbshipit-source-id: 10e420f8b6e446552c057c98eb413520c6042ee3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy is a dependency of pytorch so we should let the package manager
resolve our numpy dependency instead of doing it ourselves
Similar to pytorch/audio#1309
Signed-off-by: Eli Uriegas eliuriegas@fb.com