Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate caching logic from download for PhotoTour dataset #3448

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 24, 2021

This separates the caching logic from the download() method. Ultimately, the caching should be removed similar to #3420.

Since we have no tests and the combination of downloading and caching makes it hard to test we separate it first (this PR), add tests in a follow-up PR and only then remove the caching.

@pmeier pmeier changed the title separate caching logic from download separate caching logic from download for PhotoTour dataset Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #3448 (41865eb) into master (b266c2f) will decrease coverage by 0.14%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3448      +/-   ##
==========================================
- Coverage   76.13%   75.98%   -0.15%     
==========================================
  Files         105      105              
  Lines        9703     9701       -2     
  Branches     1556     1556              
==========================================
- Hits         7387     7371      -16     
- Misses       1836     1844       +8     
- Partials      480      486       +6     
Impacted Files Coverage Δ
torchvision/datasets/phototour.py 25.24% <20.00%> (-0.01%) ⬇️
torchvision/datasets/cifar.py 90.00% <0.00%> (-5.00%) ⬇️
torchvision/datasets/caltech.py 79.31% <0.00%> (-4.60%) ⬇️
torchvision/datasets/voc.py 92.30% <0.00%> (-2.20%) ⬇️
torchvision/datasets/vision.py 68.96% <0.00%> (-1.73%) ⬇️
torchvision/transforms/_transforms_video.py 88.88% <0.00%> (-0.35%) ⬇️
torchvision/models/mobilenetv2.py 86.95% <0.00%> (-0.28%) ⬇️
torchvision/transforms/_functional_video.py 95.23% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b266c2f...fc9c0ae. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

torchvision/datasets/phototour.py Show resolved Hide resolved
@fmassa fmassa merged commit 47e59b1 into pytorch:master Mar 1, 2021
@pmeier pmeier deleted the phototour-separate-caching branch March 1, 2021 10:15
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Reviewed By: fmassa

Differential Revision: D26756282

fbshipit-source-id: bb63f0cc2bcba111dd5a7d215334fc49eca87955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants