Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include intended structure of root directory in docstring of Kinetics400 #3453

Merged
merged 4 commits into from
Mar 1, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 25, 2021

Closes #3273.

@vadimkantorov
Copy link

Maybe add "example" files with other extensions? I think both mp4 and mkv appear in the torrent

@pmeier
Copy link
Collaborator Author

pmeier commented Feb 25, 2021

Maybe add "example" files with other extensions? I think both mp4 and mkv appear in the torrent

Currently we only allow .avi by default:

def __init__(self, root, frames_per_clip, step_between_clips=1, frame_rate=None,
extensions=('avi',), transform=None, _precomputed_metadata=None,

AFAIK there is no official way to download the dataset. Is the torrent you mentioned an unofficial one that is in widespread use? If so, please open an issue stating that we should allow more extensions.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #3453 (92db15c) into master (b266c2f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3453      +/-   ##
==========================================
- Coverage   76.13%   76.11%   -0.02%     
==========================================
  Files         105      105              
  Lines        9703     9697       -6     
  Branches     1556     1556              
==========================================
- Hits         7387     7381       -6     
  Misses       1836     1836              
  Partials      480      480              
Impacted Files Coverage Δ
torchvision/datasets/kinetics.py 40.00% <ø> (ø)
torchvision/transforms/_transforms_video.py 88.88% <0.00%> (-0.35%) ⬇️
torchvision/models/mobilenetv2.py 86.95% <0.00%> (-0.28%) ⬇️
torchvision/transforms/_functional_video.py 95.23% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4076d7b...80d9639. Read the comment docs.

@vadimkantorov
Copy link

vadimkantorov commented Feb 26, 2021

The torrent (https://academictorrents.com/details/184d11318372f70018cf9a72ef867e2fb9ce1d26) is not official as well. But from what I can understand, it was also downloaded with youtube-dl, so it probably makes sense to make extensions contain mp4, mkv, webm by default.

Attached torrent file lists:

They contain mp4, mkv and webm files.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa
Copy link
Member

fmassa commented Mar 1, 2021

I'm ok allowing for more extensions than .avi in a follow-up PR

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 1, 2021

I'm ok allowing for more extensions than .avi in a follow-up PR

@vadimkantorov Do you want to give this a shot? 🙂

@fmassa fmassa merged commit 5266a72 into pytorch:master Mar 1, 2021
@pmeier pmeier deleted the improve-kinetics400-docs branch March 1, 2021 10:23
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
…400 (#3453)

Summary:
* include intended structure of root directory in docstring of Kinetics400

* fix syntax

Reviewed By: fmassa

Differential Revision: D26756276

fbshipit-source-id: 5e94eaff792f4f0ee4e83867bd4d24db66c403e0

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is expected Kinetics400 dataset directory structure?
5 participants