Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify _get_script_fn in test_ops.py #3541

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

NicolasHug
Copy link
Member

This PR removes the wrappers used in get_srcipt_gn as they're not needed anymore.

I'm not sure we can completely get rid of get_script_fn, as it doesn't seem possible to script self.fn: NotSupportedError: Compiled functions can't take variable number of arguments or use keyword-only arguments with defaults:.

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #3541 (8cefd56) into master (3428a7d) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3541      +/-   ##
==========================================
- Coverage   79.26%   78.75%   -0.51%     
==========================================
  Files         105      105              
  Lines        9742     9750       +8     
  Branches     1564     1566       +2     
==========================================
- Hits         7722     7679      -43     
- Misses       1533     1581      +48     
- Partials      487      490       +3     
Impacted Files Coverage Δ
torchvision/datasets/flickr.py 25.64% <0.00%> (-73.08%) ⬇️
torchvision/models/detection/_utils.py 82.58% <0.00%> (-0.53%) ⬇️
torchvision/transforms/autoaugment.py 94.04% <0.00%> (-0.08%) ⬇️
torchvision/transforms/functional_tensor.py 79.92% <0.00%> (+0.07%) ⬆️
torchvision/__init__.py 63.88% <0.00%> (+2.77%) ⬆️
torchvision/io/video.py 82.06% <0.00%> (+3.26%) ⬆️
torchvision/io/__init__.py 89.65% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3428a7d...264ebb2. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@fmassa fmassa merged commit 7992eb5 into pytorch:master Mar 10, 2021
facebook-github-bot pushed a commit that referenced this pull request Mar 18, 2021
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Reviewed By: fmassa

Differential Revision: D27128008

fbshipit-source-id: 54d196b7e08943eca229e175d3132f22ed59cdbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants