Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test skipping for windows platform and avoid skipping MacOS #3548

Merged
merged 3 commits into from
Mar 12, 2021

Conversation

NicolasHug
Copy link
Member

The current condition for skipping tests on windows:

@unittest.skipIf('win' in sys.platform, 'temporarily disabled on Windows')

is also a match for macos ('darwin'): https://docs.python.org/3/library/sys.html#sys.platform

This PR fixes those so that the tests are only skipped on windows platforms.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #3548 (5b8cb3a) into master (9a08e47) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3548      +/-   ##
==========================================
- Coverage   78.86%   78.86%   -0.01%     
==========================================
  Files         105      105              
  Lines        9752     9750       -2     
  Branches     1567     1567              
==========================================
- Hits         7691     7689       -2     
  Misses       1574     1574              
  Partials      487      487              
Impacted Files Coverage Δ
torchvision/datasets/mnist.py 55.21% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a08e47...9af43bb. Read the comment docs.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datumbox datumbox merged commit 652a70f into pytorch:master Mar 12, 2021
facebook-github-bot pushed a commit that referenced this pull request Mar 18, 2021
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: fmassa

Differential Revision: D27128002

fbshipit-source-id: eb3ecdca811d5ec965234f45e937c759a4a70361
@NicolasHug NicolasHug added the bug label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants