Remove hardcoded dependency version for sphinx #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
changed the title
NicolasHug
commented
Apr 12, 2021
| @@ -2,7 +2,7 @@ | |||
| # | |||
|
|
|||
| # You can set these variables from the command line. | |||
| SPHINXOPTS = -W # turn warnings into errors | |||
| SPHINXOPTS = # -W # turn warnings into errors | |||
There was a problem hiding this comment.
The new sphinx version generates a bunch of new warnings. If that's OK I'll fix these in another PR to keep this one self contained.
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Summary: * Try using the pyortch theme * directly embed script in layout.html instead * use more mordern script Reviewed By: NicolasHug Differential Revision: D28169165 fbshipit-source-id: 564c5babbc3a96fc32fc9ada891dc2bdd339eb74 Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3511
Towards #3652
This PR removes the old sphinx version pinning, and remove the use of the
sphinxcontrib-googleanalytics(which was the reason why we had to pin sphinx).The new rendered docs properly embed the script in the header: https://510696-73328905-gh.circle-artifacts.com/0/docs/index.html
The solution was adapted from https://www.ericholscher.com/blog/2009/apr/5/adding-google-analytics-sphinx-docs/
Perhaps the pytorch theme could support this out of the box: pytorch/pytorch_sphinx_theme#109