Fix test_random_autocontrast flakyness #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2021
Summary: * fix test * more robust test * flake8 Reviewed By: NicolasHug Differential Revision: D28169163 fbshipit-source-id: 1059180968ad3bceff41c48e5c6644461634fdae Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaky and actually fails in a bunch of random seeds.
Minor differences may happen due to floating point errors. For example with
torch.manual_seed(0)you'd get(img - minimum) * scale)equal to254.999969482421875000000. This will be floored to 254 with the tensors but it's properly set to 255 in PIL. Callinground()doesn't work because the same issue can happen but in PIL instead of torchvision, so the check would still fail on other seeds.To fix the flakyness we ensure that the max abs difference is no greater than 1, and that such difference happen on less that 5% of the pixels. The new test passes on all seeds in
[0, 999]