Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up test accept behaviour #3759

Merged
merged 2 commits into from
May 4, 2021
Merged

Clean up test accept behaviour #3759

merged 2 commits into from
May 4, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented May 3, 2021 •
edited

Make the EXPECTTEST_ACCEPT env variable operate like PYTORCH_TEST_WITH_SLOW and some minor clean up of the docstrings.

@datumbox datumbox requested a review from fmassa May 3, 2021 09:05
NicolasHug
NicolasHug approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@NicolasHug NicolasHug merged commit 3e847dc into pytorch:master May 4, 2021
@datumbox datumbox deleted the tests/accept_cleanup branch May 4, 2021 09:18
facebook-github-bot pushed a commit that referenced this pull request May 17, 2021
@NicolasHug @facebook-github-bot
[fbsync] Clean up test accept behaviour (#3759)
3c41c9c 
Reviewed By: prabhat00155

Differential Revision: D28473316

fbshipit-source-id: f9457a5400104d58135e5f8f66f38b89274d53b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@datumbox @NicolasHug @facebook-github-bot