Use torch.testing.assert_close in common_utils.py #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
May 21, 2021
| @@ -139,7 +141,8 @@ def assertExpected(self, output, name, prec=None): | |||
| raise RuntimeError("The output for {}, is larger than 50kb".format(filename)) | |||
| else: | |||
| expected = torch.load(expected_file) | |||
| self.assertEqual(output, expected, prec=prec) | |||
| rtol = atol = prec or self.precision | |||
There was a problem hiding this comment.
for ref self.assertEqual is currently setting prec to self.precision if it's None (as done above)
and the check was
tolerance = prec + prec * abs(a.max())
self.assertLessEqual(max_err, tolerance, message)
So the changes LGTM here
NicolasHug
commented
May 21, 2021
There was a problem hiding this comment.
I can't approve as I'm the PR author, but this is @pmeier 's work, LGTM when green
…ion into assert_close_common_utils
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2021
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: vincentqb, cpuhrsch Differential Revision: D28679991 fbshipit-source-id: 46e760f6c01c4a8147f5ec373f682b6da96e295a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3865