Use torch.testing.assert_close in datasets_video_utils.py #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
May 21, 2021
|
|
||
| @unittest.skipIf(not io.video._av_available(), "this test requires av") | ||
| def test_video_clips(self): | ||
| with get_list_of_videos(num_videos=3) as video_list: | ||
| video_clips = VideoClips(video_list, 5, 5, num_workers=2) | ||
| self.assertEqual(video_clips.num_clips(), 1 + 2 + 3) | ||
| assert video_clips.num_clips() == 1 + 2 + 3 |
There was a problem hiding this comment.
technically we could have saved the assert int_a == int_b statements for other PRs but it was reasonably straightforward here so I went for it
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2021
…3875) Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: vincentqb, cpuhrsch Differential Revision: D28679973 fbshipit-source-id: bbefadc7cf742cfa07c11c4191d8badabaccfd84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3865