Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing SSD and SSDlite docs #3896

Merged
merged 3 commits into from
May 22, 2021
Merged

Conversation

datumbox
Copy link
Contributor

Correcting numbers on models, adding necessary links and refs on plot.

# :func:`~torchvision.models.detection.retinanet_resnet50_fpn`. For more details
# :func:`~torchvision.models.detection.retinanet_resnet50_fpn`, an SSDlite with
# :func:`~torchvision.models.detection.ssdlite320_mobilenet_v3_large` or an SSD with
# :func:`~torchvision.models.detection.ssd300_vgg16`. For more details
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to undo this. I'm not sure what criteria we used to add models here but clearly does not scale to add all of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine, once it becomes intractable we can think of a more holistic approach, but it doesn't overload the example for now

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@NicolasHug NicolasHug merged commit b2d4d8a into pytorch:master May 22, 2021
@datumbox datumbox deleted the docs/ssd_ssdlite branch May 23, 2021 09:05
facebook-github-bot pushed a commit that referenced this pull request May 25, 2021
Reviewed By: vincentqb, cpuhrsch

Differential Revision: D28679974

fbshipit-source-id: b6eb793d05648ec37f48e0b54cd6892d7a0f6fdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants