New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for files with periods in name #4099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @adamjstewart, thanks for the PR! I have two comments inline.
c32d5ac
to
1e5252c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @adamjstewart!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adamjstewart and @pmeier for the review!
Reviewed By: NicolasHug Differential Revision: D29369896 fbshipit-source-id: c3de547efcfef93bcd66bdeb249178cfe39538e7
Previously, files like
foo.bar.zip
orfoo.bar.tar.gz
could not be extracted. This PR adds support for files with periods in their name.Examples of datasets like this include:
This is a follow-up to #3443
@pmeier @calebrob6