-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ViT] Graduate ViT from prototype #5173
Conversation
💊 CI failures summary and remediationsAs of commit 8d6b0d3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sallysyw There are a few more things to be done to complete the migration:
The above were omitted earlier as the model was in prototype but now that it graduates, they need to be added. |
Sure thing! Let me do it right now. |
For |
@sallysyw Everything in that file is in alphabetic order, so adding it below VGG makes sense. If anything I think removed the comments make sense because they are incorrect. Concerning the unused import, try doing: The rest of the changes look good to me. Ping me when you fix the linters to review and merge. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hey @sallysyw! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * graduate vit from prototype * nit * add vit to docs and hubconf * ufmt * re-correct ufmt * again * fix linter Reviewed By: NicolasHug Differential Revision: D33618174 fbshipit-source-id: 3a1c6d0915d59069b27ff96a982a337ba9d7690a
Discussed offline with @datumbox, now that all the concerns have been addressed, we can finally graduate ViT models from prototype.
Testing
1. Unittest
2. Test the legacy weights api
Job ID: 14506
3. Test the new weights api in prototype
Run a test job
Job ID: 14504
cc @datumbox