move JPEG reference test into separate CI job #5184
Conversation
💊 CI failures summary and remediationsAs of commit c070c6b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Thanks a lot for the PR @pmeier , I took a quick look, LMK what you think
| @@ -359,6 +359,33 @@ jobs: | |||
| - run_tests_selective: | |||
| file_or_dir: test/test_prototype_*.py | |||
|
|
|||
| unittest_jpeg_ref: | |||
| docker: | |||
| - image: condaforge/mambaforge | |||
There was a problem hiding this comment.
Any chance we could stick to conda instead of mamba, so as to stick to the current tools that we use in the rest of the job?
There was a problem hiding this comment.
We probably can (there is most likely a docker image that gives us conda), but I'm not sure we should. mamba is a re-implementation of the protocol, but faster. So we effectively waste CI resources by using conda.
There was a problem hiding this comment.
Shouldn't we rely on the same image as the other unittest jobs here, to avoid any risk of deviating from our "baseline" testing infra? I believe they all rely on conda as well so there must be a way to install conda, even if we don't choose condaforge/mambaforge as the image
There was a problem hiding this comment.
Besides our CPU workflows on Linux, none of the other workflows even use docker:
Lines 719 to 722 in d675c0c
Lines 758 to 761 in d675c0c
Lines 808 to 811 in d675c0c
Lines 846 to 849 in d675c0c
Lines 893 to 896 in d675c0c
Apart from that, they all download the miniconda installer:
There is a container for that, but again, I see no point. It makes no difference if you install the environment with conda or mamba other than the latter is significantly faster.
There was a problem hiding this comment.
I'm happy to switch all of our jobs to mamba in another PR, but could we please stick to the same workflow that the other jobs are using? There is value in avoiding discrepancies with the rest of our CI jobs.
There was a problem hiding this comment.
What other workflow? Manually installing conda and setting things up or can I at least use a docker image with conda pre-installed?
There was a problem hiding this comment.
Sorry I'm a bit confused: what prevents us from staying as close as possible to unittest_linux_cpu: ?
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
…into jpeg-reference-ci
| # against libjpeg. By installing Pillow from conda-forge, it uses whatever jpeg library is already present instead of | ||
| # packaging one. |
There was a problem hiding this comment.
, it uses whatever jpeg library is already present instead of
packaging one.
I'm not sure I understand what this means. Should we just say "By installing Pillow from conda-forge, we make sure that pillow is built against libjpeg" ?
| @@ -359,6 +359,33 @@ jobs: | |||
| - run_tests_selective: | |||
| file_or_dir: test/test_prototype_*.py | |||
|
|
|||
| unittest_jpeg_ref: | |||
| docker: | |||
| - image: condaforge/mambaforge | |||
There was a problem hiding this comment.
Sorry I'm a bit confused: what prevents us from staying as close as possible to unittest_linux_cpu: ?
Addresses #5162 (comment). This is the newly added CI job.
cc @seemethere