Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pyav to <10 #6789

Merged
merged 3 commits into from
Oct 19, 2022
Merged

pin pyav to <10 #6789

merged 3 commits into from
Oct 19, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 18, 2022

Closes #6790. This is meant as a short term fix to get the CI green again as there are multiple failures going on right now. As suggested offline, I think it would be best for the video maintainers to have a look and see if this comes from

  1. a bug in the newly released version of av
  2. a BC breaking change in the newly released version of av
  3. a bug in our video ops that only now has been surfaced
  4. usage of deprecated functionality in our video ops that now has been removed
  5. a bug in our test setup
  6. ...

If we have a clearer picture, this PR can be reverted and whatever reasonable fix can be merged.

Copy link
Contributor

@YosuaMichael YosuaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , this is a good short term fix for the CI!

@pmeier
Copy link
Collaborator Author

pmeier commented Oct 18, 2022

The new CPU tests on GHA are also affected. I need to fix them as well. Please do not merge until further notice.

@pmeier
Copy link
Collaborator Author

pmeier commented Oct 19, 2022

The only CI failures left are the ones reported in #6794.

@pmeier pmeier merged commit 78fdaf3 into pytorch:main Oct 19, 2022
@pmeier pmeier deleted the pyav branch October 19, 2022 09:21
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2022
Summary:
* pin pyav to <10

* pin av in GHA workflows as well

* also pin in M1 workflow

Reviewed By: YosuaMichael

Differential Revision: D40588161

fbshipit-source-id: 7583178f8f7697a4b4e3a9e518ae2f81e00b535f
YosuaMichael pushed a commit to YosuaMichael/vision that referenced this pull request Oct 27, 2022
* pin pyav to <10

* pin av in GHA workflows as well

* also pin in M1 workflow
atalman pushed a commit that referenced this pull request Dec 9, 2022
* pin pyav to <10

* pin av in GHA workflows as well

* also pin in M1 workflow

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

av==10.0.0 breaks CI
4 participants