Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dropout overwrites on EfficientNet #7031

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

datumbox
Copy link
Contributor

Fixes #7029

Also fixes the linter breakage caused by an earlier PR.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vasilis. Could you link the PR that introduced the lint errors?

test/smoke_test.py Show resolved Hide resolved
torchvision/models/efficientnet.py Show resolved Hide resolved
@datumbox
Copy link
Contributor Author

The CI is completely broken but I tested the tests locally and they all pass. Merging.

@datumbox datumbox merged commit 5785e2b into pytorch:main Dec 12, 2022
@datumbox datumbox deleted the models/efficientnet_dropout branch December 12, 2022 09:40
facebook-github-bot pushed a commit that referenced this pull request Dec 16, 2022
Reviewed By: YosuaMichael

Differential Revision: D42046598

fbshipit-source-id: 5ae216e3f416bfc63dc296915da86a6a2a4ed8fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EfficientNet documentation is (probably) misleading
3 participants