Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.5 in save_images so we round to nearest int #754

Merged
merged 1 commit into from Feb 21, 2019
Merged

Conversation

ssnl
Copy link
Contributor

@ssnl ssnl commented Feb 20, 2019

cc @fmassa

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #754 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   40.31%   40.31%           
=======================================
  Files          29       29           
  Lines        2746     2746           
  Branches      432      432           
=======================================
  Hits         1107     1107           
  Misses       1563     1563           
  Partials       76       76
Impacted Files Coverage Δ
torchvision/utils.py 51.92% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75b814...73b9c82. Read the comment docs.

@surgan12
Copy link
Contributor

@ssnl , isnt this just trying to round to ceil ?

@ssnl
Copy link
Contributor Author

ssnl commented Feb 21, 2019 via email

@surgan12
Copy link
Contributor

Oh Yes, you are right !

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot Simon!

@fmassa fmassa merged commit 1b4455a into pytorch:master Feb 21, 2019
@ssnl ssnl deleted the im branch February 21, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants