Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused packaging/pkg_helpers.bash, Remove CONDA_CHANNEL_FLAGS #7656

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jun 6, 2023

Remove unused

packaging/pkg_helpers.bash

CONDA_CHANNEL_FLAGS is not initialized variable. And its not required to install

libpng "jpeg<=9b"

These libraries should be installed from default channel.

Here is the reference from current workflow:
https://github.com/pytorch/vision/actions/runs/5176600132/jobs/9325627772#step:7:40

Everything is routed via Nova now.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7656

Note: Links to docs will display an error until the docs builds have been completed.

❌ 30 New Failures

As of commit e3e55b6:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman changed the title Remove empty variable Remove unused packaging/pkg_helpers.bash, Remove CONDA_CHANNEL_FLAGS Jun 6, 2023
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atalman

@atalman atalman merged commit 657027f into pytorch:main Jun 6, 2023
12 of 42 checks passed
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Hey @atalman!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit to pytorch/audio that referenced this pull request Jun 6, 2023
Summary:
We are using Project Nova workflows now. These are not required.

Same as: pytorch/vision#7656

Pull Request resolved: #3409

Reviewed By: mthrok

Differential Revision: D46494331

Pulled By: atalman

fbshipit-source-id: a642ae55b75482918e0afb7c55dc876bc8356e70
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2023
…EL_FLAGS (#7656)

Reviewed By: vmoens

Differential Revision: D46724126

fbshipit-source-id: b8be6f2f142e80f41c10c628e9dc397806a33e0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants