Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with jitted AA transforms in v2 and added tests #7839

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 16, 2023

Error reported in #7159

2023-08-15T10:23:55.6431105Z E   RuntimeError: The following operation failed in the TorchScript interpreter.
2023-08-15T10:23:55.6431482Z E   Traceback of TorchScript (most recent call last):
2023-08-15T10:23:55.6431884Z E     File "/pytorch/vision/torchvision/transforms/autoaugment.py", line 268, in forward
2023-08-15T10:23:55.6432243Z E                   fill = [float(fill)] * channels
2023-08-15T10:23:55.6432525Z E               elif fill is not None:
2023-08-15T10:23:55.6432816Z E                   fill = [float(f) for f in fill]
2023-08-15T10:23:55.6433084Z E                           ~~~~~ <--- HERE
2023-08-15T10:23:55.6433303Z E       
2023-08-15T10:23:55.6433631Z E           transform_id, probs, signs = self.get_params(len(self.policies))
2023-08-15T10:23:55.6433925Z E   RuntimeError: stod

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 16, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7839

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 0fe1c54 with merge base 37081ee (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. Thanks Victor!

@vfdev-5 vfdev-5 changed the title Fixed issue with jitted AA and added tests Fixed issue with jitted AA transforms in v2 and added tests Aug 16, 2023
v2_transforms.InterpolationMode.BILINEAR,
],
)
def test_randaug_jit(self, interpolation):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 @pmeier instead of adding new tests here, shouldn't we be writing the new ones in test_transforms_v2_refactored.py?

We're going to delete this file, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolasHug can we merge this PR and address your comment later ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to delete this file, right?

Yes. Indeed, all new tests should go into test_transforms_v2_refactored.py. No strong opinion of doing this now or later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's do it later

@vfdev-5 vfdev-5 merged commit 9c4f738 into pytorch:main Aug 22, 2023
62 of 63 checks passed
@vfdev-5 vfdev-5 deleted the v2-vs-v1-fixes branch August 22, 2023 17:15
@github-actions
Copy link

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

This was referenced Aug 31, 2023
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
…7839)

Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900412

fbshipit-source-id: 516d3744e6c6115394abd80918ba4ad87eb5c5d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants