Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup README.md #7847

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Cleanup README.md #7847

merged 2 commits into from
Aug 17, 2023

Conversation

NicolasHug
Copy link
Member

Some cleanup to our README and contributing guides which had accumulated a bit of noise / redundancy over the years.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 17, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7847

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures, 1 Unrelated Failure

As of commit ffb2da7 with merge base a7b52a6 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@@ -1,11 +1,37 @@
Reading/Writing images and videos
=================================
Decoding / Encoding images and videos
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved the image section before the video one.

```
pip install torchvision
```
## Image Backends
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this section is relevant these days. I'm tempted to remove it. @pmeier @vfdev-5 any thought?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'll just keep it for now. I wouldn't even know what to do with the "video backend" section either...

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@NicolasHug NicolasHug merged commit 74f50d9 into pytorch:main Aug 17, 2023
8 of 15 checks passed
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 5, 2023
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900407

fbshipit-source-id: 8559cfa88528b2d5494dba8d30fd1997768589fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants