Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port convert_bounding_box_format tests #7933

Merged
merged 4 commits into from Sep 6, 2023
Merged

port convert_bounding_box_format tests #7933

merged 4 commits into from Sep 6, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 5, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7933

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

❌ 19 New Failures, 1 Unrelated Failure

As of commit cc2e45a with merge base 1f94320 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , LGTM with some minor comments below.

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved
test/test_transforms_v2_refactored.py Show resolved Hide resolved
test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved
test/test_transforms_v2_refactored.py Show resolved Hide resolved
@pmeier pmeier merged commit 4103552 into pytorch:main Sep 6, 2023
42 of 62 checks passed
@pmeier pmeier deleted the port/convert_bounding_box_format branch September 6, 2023 07:43
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
@NicolasHug @facebook-github-bot
[fbsync] port convert_bounding_box_format tests (#7933)
a940976 
Reviewed By: matteobettini

Differential Revision: D49600779

fbshipit-source-id: 6e34703649ad306f2adc4b649998af4eeb0a5066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: tests module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmeier @NicolasHug @facebook-github-bot