Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix weight docs #7993

Merged
merged 2 commits into from Sep 25, 2023
Merged

fix weight docs #7993

merged 2 commits into from Sep 25, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 25, 2023

Broken in #7795.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7993

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 24 Unrelated Failures

As of commit c1f7035 with merge base 7ba3d7e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier linked an issue Sep 25, 2023 that may be closed by this pull request
Weight docs are broken #7992
Closed
@pmeier
Copy link
Collaborator Author

pmeier commented Sep 25, 2023

Preview from this PR: https://docs-preview.pytorch.org/pytorch/vision/7993/models/generated/torchvision.models.vgg11_bn.html#torchvision.models.VGG11_BN_Weights

image

NicolasHug
NicolasHug approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

(Just removing the bug label so we don't get confused in the release notes)

@NicolasHug NicolasHug merged commit 68fbd3c into pytorch:main Sep 25, 2023
11 of 24 checks passed
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Sep 25, 2023
@pmeier @NicolasHug
fix weight docs (pytorch#7993)
79a2a70 
Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
@pmeier pmeier deleted the fix-weights-docs branch September 26, 2023 09:37
facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
@NicolasHug @facebook-github-bot
[fbsync] fix weight docs (#7993)
bfafa89 
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: matteobettini

Differential Revision: D49600766

fbshipit-source-id: 8853fd0b39e366bf34a4929b012f5e6751312de8
NicolasHug added a commit that referenced this pull request Oct 5, 2023
@NicolasHug @pmeier
[Cherry pick] fix weight docs (#7993) (#7994)
349c66d 
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
@NicolasHug NicolasHug mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: documentation weights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weight docs are broken
3 participants
@pmeier @NicolasHug @facebook-github-bot