-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSRoiAlign: SymInt support + meta-implem #8058
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
440f7c4
Add opcheck for psroialign -- currently fails
NicolasHug c6bf931
Add SymInt support for RoiAlign
NicolasHug 38e8e03
Add meta implem
NicolasHug 0de23c9
Fix meta implem. opchecks are passing
NicolasHug 70638af
Merge branch 'main' of github.com:pytorch/vision into opcheck_psroialign
NicolasHug a3b5739
Added xfail checks, but opchecks doesn't like it
NicolasHug cba29db
empty
NicolasHug 0acbe8e
Merge branch 'main' of github.com:pytorch/vision into opcheck_psroialign
NicolasHug 20068af
Remove optest as we can't xfail parametrized tests
NicolasHug feed2d7
Merge branch 'main' into opcheck_psroialign
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @zou3519
I just opened pytorch/pytorch#111797 which I believe could be a fix for the problem I'm facing here:
This test (and a bunch of others)
vision/test/test_ops.py
Lines 186 to 189 in 3fb88b3
is parametrized over cpu, CUDA and MPS, and fails on MPS.
I'm trying to
xfail
the MPS parametrization as above (lines 10-12), butoptests
complains with:The problem is, if I replace
TestPSRoIAlign.test_autograd_registration__test_backward[True-mps-0]
withTestPSRoIAlign.test_autograd_registration__test_backward
in line 10, then I'm getting and "unexpected success":There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicolasHug can the tests be run under unittest, or are they pytest only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's pytest only