Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to_pil_image and align array with tensor inputs #8097

Merged
merged 4 commits into from Nov 8, 2023
Merged

refactor to_pil_image and align array with tensor inputs #8097

merged 4 commits into from Nov 8, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Nov 7, 2023 •
edited by pytorch-bot bot

Fixes #8090 and alternative to #8091.

cc @vfdev-5

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 7, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8097

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 10 Unrelated Failures

As of commit 7af81f9 with merge base a0fcd08 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pmeier and others added 2 commits November 7, 2023 11:32
@pmeier @NicolasHug
align numpy and torch on floating point inputs
91981e6 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@pmeier
cleanup
eeb81e0
@NicolasHug NicolasHug mentioned this pull request Nov 7, 2023
Closed
NicolasHug
NicolasHug approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, LGTM when green

@pmeier pmeier merged commit 15c166a into pytorch:main Nov 8, 2023
50 of 64 checks passed
@pmeier pmeier deleted the to-pil-image branch November 8, 2023 08:51
facebook-github-bot pushed a commit that referenced this pull request Nov 16, 2023
@NicolasHug @facebook-github-bot
[fbsync] refactor to_pil_image and align array with tensor inputs (#8097
f7bc701 
)

Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D51391967

fbshipit-source-id: d64cd63a7417ceea4c7eee88e02c1866411e61f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
bug cla signed module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_pil_image different results depending on numpy/torch input
3 participants
@pmeier @NicolasHug @facebook-github-bot