Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning the padding policy in transforms.GaussianBlur docs #8246

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

talcs
Copy link
Contributor

@talcs talcs commented Feb 1, 2024

No description provided.

gaussian blur doc - mention padding policy
gaussian blue doc - mention padding policy
Copy link

pytorch-bot bot commented Feb 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8246

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 18 Unrelated Failures

As of commit cfe3d89 with merge base 6c10d08 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @talcs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @talcs . This looks good, I made some minor suggestions below. Could you also please add the same to the v2 version as well? Also make sure to sign the CLA (see comment above) so that we can merge the PR. Thank you!

torchvision/transforms/v2/_misc.py Outdated Show resolved Hide resolved
torchvision/transforms/functional.py Outdated Show resolved Hide resolved
talcs and others added 2 commits February 5, 2024 14:09
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@talcs
Copy link
Contributor Author

talcs commented Feb 5, 2024

Hey, I have accepted your commits and signed the CLA form. Thank you for helping me with it.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

torchvision/transforms/functional.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_misc.py Outdated Show resolved Hide resolved
torchvision/transforms/functional.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_misc.py Outdated Show resolved Hide resolved
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @talcs , LGTM let me merge that once the CI is green!

@NicolasHug NicolasHug moved this from Must to approved in 0.18 TODOs Mar 13, 2024
@NicolasHug NicolasHug merged commit 5501bfe into pytorch:main Mar 13, 2024
9 of 31 checks passed
@NicolasHug NicolasHug moved this from approved to done in 0.18 TODOs Mar 13, 2024
facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
#8246)

Reviewed By: vmoens

Differential Revision: D55062807

fbshipit-source-id: 9284b54f77d6664bab5714bdfac2314691413718

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants