Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private PIL kernels from __init__.py #8329

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Mar 18, 2024

This removes all the private PIL kernels from torchvision.transforms.v2.functional.__init__.py.

This is mostly to avoid users to think that those are public just because they're exposed in __init__.py. That happens more often that we'd want, and it's best to prevent that confusion.

cc @vfdev-5

Copy link

pytorch-bot bot commented Mar 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8329

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 1 Unrelated Failure

As of commit 7785b4d with merge base 924b162 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug moved this from Must to approved in 0.18 TODOs Mar 18, 2024
@NicolasHug NicolasHug merged commit 9cb639a into pytorch:main Mar 18, 2024
55 of 62 checks passed
@NicolasHug NicolasHug moved this from approved to done in 0.18 TODOs Mar 18, 2024
@NicolasHug NicolasHug deleted the aeofnalfjenljaenfaef branch March 18, 2024 12:27
facebook-github-bot pushed a commit that referenced this pull request Mar 21, 2024
Reviewed By: vmoens

Differential Revision: D55062759

fbshipit-source-id: ed6e33df97392ad90eca2938ff783063ce60acf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants