Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CocoDataset ids deterministically ordered #868

Merged
merged 1 commit into from Apr 25, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Apr 24, 2019

The keys of a dict do not have a guaranteed order.
Sorting them to ensure that the order is consistent.

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #868 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #868      +/-   ##
=========================================
- Coverage   54.43%   54.4%   -0.04%     
=========================================
  Files          36      36              
  Lines        3323    3323              
  Branches      546     546              
=========================================
- Hits         1809    1808       -1     
- Misses       1379    1380       +1     
  Partials      135     135
Impacted Files Coverage Δ
torchvision/datasets/coco.py 24.48% <0%> (ø) ⬆️
torchvision/transforms/functional.py 69.2% <0%> (-1.27%) ⬇️
torchvision/transforms/transforms.py 82.68% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a481d0...29db273. Read the comment docs.

@fmassa fmassa merged commit 6716fc5 into pytorch:master Apr 25, 2019
@fmassa fmassa deleted the coco-sorted-ids branch April 25, 2019 08:36
kmbae added a commit to kmbae/vision that referenced this pull request May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants