Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run persistent cache test on TPU CI #7038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jonb377
Copy link
Collaborator

@jonb377 jonb377 commented May 8, 2024

Persistent cache test only ran on GPU CI. This change enables it on TPU CI as well.

@jonb377 jonb377 requested a review from JackCaoG May 8, 2024 19:25
@JackCaoG JackCaoG added the tpuci label May 8, 2024
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after TPU CI passed

Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jonb377
Copy link
Collaborator Author

jonb377 commented May 8, 2024

@JackCaoG Looks like CI failed with timeout, was this the same issue you hit?

Step #4 - "run_e2e_tests": + python3 test/test_persistent_cache.py
Step #4 - "run_e2e_tests": Running tests under Python 3.10.14: /usr/local/bin/python3
Step #4 - "run_e2e_tests": [ RUN      ] PersistentCacheTest.test_persistent_cache_mp
Step #4 - "run_e2e_tests": [  FAILED  ] PersistentCacheTest.test_persistent_cache_mp
Step #4 - "run_e2e_tests": [ RUN      ] PersistentCacheTest.test_persistent_cache_single_device
Step #4 - "run_e2e_tests": ++ kubectl get pod/xla-test-job-zqtd5 -o 'jsonpath={.status.containerStatuses[?(@.name=="xla-test")].state.terminated.exitCode}'
Step #4 - "run_e2e_tests": + exit 137

I can repro locally with the XLA_USE_SPMD env var set, but it passes without that env var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants