Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it's a simple draft attempt to add support for enums (#334).
The main idea is to pass states to
machine
as we can do it with strings toState
class and work with it.I added some tests to illustrate the api
Example:
But now in the code base, we have many conditions
isinstance(state, string_types, )
orisinstance(state, State)
. For support enums i added checkisinstance(state, enum.Enum)
and it not looking good and we should drop support for python < 3.4.Any suggestions how enums should work are welcome :)
@aleneum what do you think about this implementation?