Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coverage for duplicate states in HierarchicalMachine #406

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

thedrow
Copy link
Contributor

@thedrow thedrow commented Mar 25, 2020

Coverage for these conditions were missing so I added them 馃槂.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 98.612% when pulling 4ed2e3c on thedrow:increase-coverage into 070b450 on pytransitions:master.

@aleneum
Copy link
Member

aleneum commented Mar 26, 2020

Nice! Could you add those tests to test_enum.py instead (in particular here)? This will make sure that users of Python 2.7 without the enum34 module can run the tests as well (since enum tests will be skipped).

I see that Travis' Python 2.7 job is not failing suprisingly. More surprisingly, the tests are actually executed instead of skipped. Maybe enum34 is installed by default since it is no dependency of transitions. When I run tests locally, test_enum will be skipped for Python 2.7.

@aleneum aleneum changed the base branch from master to next-release March 28, 2020 16:06
@aleneum aleneum merged commit 099dc38 into pytransitions:next-release Mar 28, 2020
@thedrow
Copy link
Contributor Author

thedrow commented Mar 29, 2020

I was about to do the changes you requested today.
Do I need to do them anyway or are you going to do so?

@thedrow thedrow deleted the increase-coverage branch March 29, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants