Separate building library and extension #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I like the idea. Does this put any restrictions on the |
| @@ -64,12 +64,18 @@ def run_tests(self): | |||
| license=LICENSE, | |||
| url='https://github.com/kmike/datrie', | |||
| classifiers=CLASSIFIERS, | |||
| libraries=[ | |||
| ('libdatrie', dict( | |||
| sources=LIBDATRIE_FILES, | |||
There was a problem hiding this comment.
Sure. Does that mean single or double quotes?
There was a problem hiding this comment.
Sorry, I was referring to indentation in the dict call.
|
Cool. Not that I know. I learnt it from http://stackoverflow.com/q/16854066/284795 The boon is "building libdatrie library" and "building datrie extension" show as separate steps in the install. |
|
Indented neatly |
|
Looks good, thanks! |
superbobry
added a commit
that referenced
this pull request
Jul 20, 2015
Separate building library and extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mike. I recently learnt how to separate building library and extension in setup.py . I'm not convinced it's any better or worse, but thought I'd share. What do you think?