Added Line Properties (LineJoin and LineCap) to Draw

[simonkolotov]

Hi.
I've added two properties to the draw object that are available in agg: line-join and line-cap.

Simon

PS
The agg version used at the current aggdraw is 2.2, which is not the latest (2.4), which - among other things - introduced some changes in the API.
Do you plan to update the AggDraw anytime soon, to include agg 2.4?

PPS
I found some additional bugs in aggdraw - which in part led me to write the change I'm offering here - namely, when widening the stroke (pen) width in a polygon, so that it intersects itself, the creates weird effects.
Would you be interested in an example that would allow you to fix that at some point?

Regards,
Simon

[jakul]

Hey Simon,

Thanks for the PR, but I'm not updating this module anymore. There are a
number of other clones of this github, who might be grateful for your
contribution - https://github.com/search?q=agg2

-- Craig Blaszczyk

2014-07-24 15:11 GMT+01:00 Simon Kolotov notifications@github.com:

Hi.
I've added two properties to the draw object that are available in agg:
line-join and line-cap.

Simon

PS
The agg version used at the current aggdraw is 2.2, which is not the
latest (2.4), which - among other things - introduced some changes in the
API.
Do you plan to update the AggDraw anytime soon, to include agg 2.4?

PPS
I found some additional bugs in aggdraw - which in part led me to write
the change I'm offering here - namely, when widening the stroke (pen) width
in a polygon, so that it intersects itself, the creates weird effects.
Would you be interested in an example that would allow you to fix that at
some point?

Regards,

Simon

You can merge this Pull Request by running

git pull https://github.com/simonkolotov/aggdraw AddLineProps

Or view, comment on, or merge it at:

#3
Commit Summary

• Added Line Properties (LineJoin and LineCap) to Draw

File Changes

• M aggdraw.cxx
  https://github.com/jakul/aggdraw/pull/3/files#diff-0 (76)

Patch Links:

• https://github.com/jakul/aggdraw/pull/3.patch
• https://github.com/jakul/aggdraw/pull/3.diff

—
Reply to this email directly or view it on GitHub
#3.

[karimbahgat]

Do I understand correctly @djhoese that this is already included in #50 and would be fixed/added once it goes through?

[djhoese]

@karimbahgat from what I can tell, yes.

[dov]

I can confirm that #50 supersedes this PR.

[djhoese]

Now that #50 is merged I think we can close this. There are still some concerns by @a-hurst about the change in default cap type and we'll address those before releasing, but as-is the master branch should have this functionality based on what @dov has said.

If any of this is wrong, let me know.