Add __getitem__ and __contains__ method to Config object #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods allow for bracket syntax access of config keys (ex.
mypkg_config['a']
) andin
checks (ex.'a' in mypkg_config
). These should make it easier fordask
to migrate away from using theconfig
dictionary that should be considered internal use only.As far as I can tell these should work in all of the expected cases since they are just wrappers around the more complicated
get
method. I'm not sure if there is a cleaner looking way to do thetry/except
inside contains without doingself[item]
.@mrocklin @jhamman