Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SerializableLock from Dask to use in Config.set #22

Merged
merged 2 commits into from Feb 5, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 5, 2022

Closes #17.

This is somewhere between a bug fix and an enhancement. This is a bug fix for a feature that was never advertised 馃槈. That feature is being able to serialize the Config object. To accomplish this the SerializableLock class has been copied over from Dask.

@djhoese djhoese added the enhancement New feature or request label Feb 5, 2022
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #22 (c45f6a6) into main (38a1f7a) will increase coverage by 0.52%.
The diff coverage is 98.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   94.42%   94.94%   +0.52%     
==========================================
  Files           4        6       +2     
  Lines         610      693      +83     
==========================================
+ Hits          576      658      +82     
- Misses         34       35       +1     
Flag Coverage 螖
unittests 94.94% <98.82%> (+0.52%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
donfig/_lock.py 96.55% <96.55%> (酶)
donfig/config_obj.py 91.05% <100.00%> (酶)
donfig/tests/test_config.py 100.00% <100.00%> (酶)
donfig/tests/test_lock.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 38a1f7a...c45f6a6. Read the comment docs.

@djhoese djhoese merged commit 5333661 into pytroll:main Feb 5, 2022
@djhoese djhoese deleted the feature-serializable-lock branch February 5, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threadlock TypeError when trying to pickle donfig object
1 participant