Fix environment variable loading only working with 4 characters #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a hardcoded
[5:]
indexing done on environment variable names that works for any package name that is 4 letters long (ex.DASK
). If the package name was longer than that then donfig wouldn't find the environment variable or rather it would assign the wrong value by not cutting enough of the prefix away.This issue wasn't caught before because all my tests used a test config name of "test" (4 characters).